Only include x-amz-acl header for AWS
#2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even in AWS S3 compatibility mode, Google now appears to reject requests that includes this header with this error: ``` Requests cannot specify both x-amz and x-goog headers ```
|
@mshibuya Would you mind reviewing this too? Build failures appear unrelated. I can't seem to reproduce them locally. |
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Dec 17, 2018
Even in AWS S3 compatibility mode, Google now appears to reject requests that includes this header with this error: ``` Requests cannot specify both x-amz and x-goog headers ``` This has been submitted upstream via carrierwaveuploader/carrierwave#2356. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53846.
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Dec 17, 2018
Even in AWS S3 compatibility mode, Google now appears to reject requests that includes this header with this error: ``` Requests cannot specify both x-amz and x-goog headers ``` This has been submitted upstream via carrierwaveuploader/carrierwave#2356. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53846.
|
Ok, #2357 fixes the failing builds. |
tigefa4u
pushed a commit
to tigefa4u/gitlabhq
that referenced
this pull request
Dec 17, 2018
Even in AWS S3 compatibility mode, Google now appears to reject requests that includes this header with this error: ``` Requests cannot specify both x-amz and x-goog headers ``` This has been submitted upstream via carrierwaveuploader/carrierwave#2356. Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/53846.
|
Great, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even in AWS S3 compatibility mode, Google now appears to reject requests
that includes this header with this error: