Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MiniMagick: use read method to get file data #2349

Merged
merged 2 commits into from
Dec 24, 2018
Merged

MiniMagick: use read method to get file data #2349

merged 2 commits into from
Dec 24, 2018

Conversation

artygus
Copy link
Contributor

@artygus artygus commented Oct 30, 2018

Fixes #1947 and the issue described in #2299

When a file is uploaded and it is still not saved yet, getting its width or height fails with an error message something like in #1947. So this fix uses the cached file first if it is available or use previous strategy to continue.

@mshibuya mshibuya merged commit 0dc4277 into carrierwaveuploader:master Dec 24, 2018
@mshibuya
Copy link
Member

Makes sense, thanks!

@mshibuya mshibuya mentioned this pull request Dec 24, 2018
Closed
mshibuya added a commit that referenced this pull request Dec 24, 2018
@mshibuya
Minor fixes of #2349
a0e0330
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Open
@sync-by-unito sync-by-unito bot mentioned this pull request Apr 9, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with MiniMagick height and width methods
2 participants
@artygus @mshibuya