Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change file size of error message to human size #2199

Merged
merged 3 commits into from
Jul 1, 2017
Merged

Change file size of error message to human size #2199

merged 3 commits into from
Jul 1, 2017

Conversation

aki77
Copy link
Contributor

@aki77 aki77 commented Jun 19, 2017

before
File size should be less than 1234567

after
File size should be less than 1.18 MB

@thiagofm
Copy link
Member

Can you write a test for it?

Thanls.

@aki77
Copy link
Contributor Author

aki77 commented Jul 1, 2017

Done.

@mshibuya mshibuya merged commit 010d49d into carrierwaveuploader:master Jul 1, 2017
@mshibuya
Copy link
Member

mshibuya commented Jul 1, 2017

Nice, thanks!

@aki77
Copy link
Contributor Author

aki77 commented Jul 1, 2017

Thanks!

@aki77 aki77 deleted the fix-errormessage branch July 1, 2017 07:18
@ibrahima ibrahima mentioned this pull request Apr 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aki77 @thiagofm @mshibuya