Fixing #1977 Invalid locale in CarrierWave::MiniMagick#manipulate! #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gick#manipulate! Since ([commit on May 9, 2014](ruby-i18n/i18n@b5703d7)) enforce_available_locales in I18n is true by default, the aproach which implies on default error messages from `:en` locale is broked for all apps where `:en` is not available locale.
|
Agreed, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1977 Invalid locale in CarrierWave::MiniMagick#manipulate!
Since (commit on May 9, 2014) enforce_available_locales in I18n is true by default, the aproach which implies on default error messages from
:enlocale is broked for all apps where:enis not available locale. It's very suddenly when image processing raiseI18n::InvalidLocaleerror.In this pull request I propose to remove the "default fallback" and let carrierwave users decide themselves how to deal with missed locales and/or translations.