Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed series of pep8 fixes surfacinging in python 3.11 flake8 checks #1149

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

caronc
Copy link
Owner

@caronc caronc commented Jul 2, 2024

Description:

Related issue (if applicable): #1148

Issues surfaced recently for some reason and became visible on the attached PR.

This corrects the E502 PEP8 issues that have clearly existed long before.

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • No lint errors (use flake8)
  • 100% test coverage

Testing

Unit tests pass is all that is tested here

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.28%. Comparing base (35ed4d2) to head (e0a9d99).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
+ Coverage   99.16%   99.28%   +0.12%     
==========================================
  Files         142      142              
  Lines       18429    18440      +11     
  Branches     3312     3763     +451     
==========================================
+ Hits        18275    18309      +34     
+ Misses        134      121      -13     
+ Partials       20       10      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caronc caronc merged commit 6733953 into master Jul 2, 2024
13 checks passed
@caronc caronc deleted the 2024-07-01-pep8-fixes branch July 26, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants