Move import refs to their own block. #4103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on #4101 |
chandlerc
approved these changes
Jul 3, 2024
zygoloid
reviewed
Jul 3, 2024
toolchain/check/import_ref.cpp
Outdated
Comment on lines
68
to
69
| // visible in textual IR. Adding it to the file block is arbitrary but is the | ||
| // best place we have right now. |
There was a problem hiding this comment.
Should we also remove the last line of this comment?
There was a problem hiding this comment.
The comment in context.h was copying the important bits, I'd meant to remove this. So I've cut the detail out since it's now on the vector.
jonmeow
force-pushed
the
imports-refs-block
branch
from
89f8416
to
f35f5c1
Compare
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jul 3, 2024
The use of ArrayStack here is intended to simplify the logic, and also make better use of the inst heap allocations. Prior changes #4101 and #4103 removed the less related logic from InstBlockStack, although #4103 is the actual part that blocked using ArrayStack. BTW, note the PrintForStackDump implementation was incorrect because it didn't apply size_. This simplification fixes the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This executes on a TODO in AddImportRef to add instructions to their own block instead of the File block. This has an important consequence of removing a pattern from InstBlockStack that added to blocks not currently at the top, cleaning up an issue for ArrayStack. The delta here is then mostly in different formatting of the import refs, a consequence of the separation.