Clear database state in the mock daemon after each lxdSuiteTest #3320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently unit tests based on lxdSuiteTest all share the same database, meaning that state left by certain tests can influence other tests (for instance it's not possible to create a pool with the same name in two different tests). This change resets the db state after each individual test run, increasing isolation between tests. Signed-off-by: Free Ekanayaka <[email protected]>
freeekanayaka
force-pushed
the
clear-db-state-after-each-test-using-lxdSuiteTest
branch
from
7c5c5ba
to
4e42226
Compare
freeekanayaka
deleted the
clear-db-state-after-each-test-using-lxdSuiteTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently unit tests based on lxdSuiteTest all share the same
database, meaning that state left by certain tests can influence other
tests (for instance it's not possible to create a pool with the same
name in two different tests).
This change resets the db state after each individual test run,
increasing isolation between tests.
Note that we need to reset the daemon config in-memory map because
it's a cache of the db state. I think there other cases of such caches, but
it should be fine to deal with them as we go. For now current tests are
happy with this change.
Signed-off-by: Free Ekanayaka [email protected]