Rewritten list query, test and fix [#82]

[miro-balaz]

Solves #82

Adds test to expose slowness of list query (#82)
Original list query had maybe quadratic complexity (plot) in terms of number of rows with same name.
New query passes the test, it still has superlinear complexity. But it has to be taken with grain of salt as I meassured individual updates.

Test performs two subsequents batches of 1000 updates.

Orignal query

• duration of first batch: 18 320 405 224ns
• duration of subsequent batch: 105 316 382 474ns

New Query

• duration of first batch: 2 372 000 975ns
• duration of subsequent batch duration: 2 684 759 515ns

Future work: By having specialized query for getting single name,(no prefix or range), we can have even faster, constant time complexity of list.

[ktsakalozos]

Thank you for this PR @miro-balaz stay tuned for a proper review.

[ktsakalozos]

You can install MicroK8s with this patch with:

sudo snap install microk8s --classic --channel=latest/edge/dqlite-list

[berkayoz]

Hey @miro-balaz,

Proposed list query seems to perform better under general circumstances where number of updated rows(with same name) are generally small. So LGTM.

Before merging, could you please verify you have submitted the CLA form? (If you are a first time contributor) And could you also rebase the PR to include the CLA check workflow?

Thanks.

[ktsakalozos]

@miro-balaz thank you for this work we would like to merge it. Could you please rebase and sign the CLA so we can distribute the code? Thank you.

[miro-balaz]

Hallo, thanks for cooperation. I have some questions. If I remember correctly I have signed CLA before ( canonical/microk8s#2809). I hope it is still valid. I am not sure what should I rebase and how. Do you mean to force rebase branch in my fork? something like this tutorial https://github.com/AshleyGrant/git-tutorials/blob/master/Rebase%20Fork%20Branch%20to%20Upstream%20Master.md ? - git remote add upstream $URL where $URL is the HTTPS clone URL of the upstream repo - git pull --rebase upstream master - git checkout <featurebranch> - git rebase master - git push --force ut 20. 2. 2024 o 6:39 Konstantinos Tsakalozos ***@***.***> napísal(a):

…

@miro-balaz <https://github.com/miro-balaz> thank you for this work we would like to merge it. Could you please rebase and sign the CLA so we can distribute the code? Thank you. — Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC3IHU5IUCU4BH35LAKTZT3YUQZI7AVCNFSM6AAAAABCX66XACVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNJTGUZDAMZXG4> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[berkayoz]

I've went ahead with the rebase, everything seems to be good to go.

I'll go ahead with the merge,
Thanks @miro-balaz

[miro-balaz]

Thanks, I would like to contribute more to this project, I already am familiar with codebase. Is there any mailing list or slack? I would like to know bit more about the future and why certain decisions were made. st 21. 2. 2024 o 9:28 Berkay Tekin Öz ***@***.***> napísal(a):

…

Merged #83 <#83> into master. — Reply to this email directly, view it on GitHub <#83 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AC3IHU7HY3IHYU56LMIPRX3YUWV2LAVCNFSM6AAAAABCX66XACVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJRHA3TENRSGUZTMMQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>