Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): add examples #507

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vados-cosmonic
Copy link
Contributor

This commit adds examples to the jco, some of which are/will be referenced from the component-model book (https://component-model.bytecodealliance.org/).

@vados-cosmonic
Copy link
Contributor Author

I'm going to assume that the failing test is unrelated, considering none of the actually important code changed. Possibly a problem with ubuntu latest?

@guybedford
Copy link
Collaborator

Yes, just a flake.

@vados-cosmonic vados-cosmonic force-pushed the chore(examples)=add-examples branch 10 times, most recently from 96b3ca3 to 5067303 Compare October 2, 2024 17:09
@vados-cosmonic
Copy link
Contributor Author

vados-cosmonic commented Oct 2, 2024

Hey @guybedford this is finally ready for review -- example CI is working properly

[EDIT] I'm also fine not committing the per-project WASM binaries -- so I could take those out... Would lighten the repo a bit

This commit adds examples to the jco, some of which are/will be
referenced from the component-model book (https://component-model.bytecodealliance.org/).

Signed-off-by: Victor Adossi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants