Skip to content
This repository has been archived by the owner on Jan 23, 2021. It is now read-only.

fixes #6 #7

Merged
merged 1 commit into from
Jun 10, 2015
Merged

fixes #6 #7

merged 1 commit into from
Jun 10, 2015

Conversation

abaldwin99
Copy link
Contributor

fixes issue where extension wouldn't work after brackets restart

fixes issue where extension wouldn't work after brackets restart
@abaldwin99
Copy link
Contributor Author

I'm new to brackets and writing extensions but this alleviated my issue and seemed to have no adverse side effects.

@ghost
Copy link

ghost commented Jun 9, 2015

Thanks blah73, your fix solved the problem. Also the error that I had in the status bar is gone.

@bryanjhv
Copy link
Owner

It seems Brackets is changing its API, but the problem all are facing is after a PR I merged... Can you try db6d41a to see if it is due to that?
BTW, as my comment in #6 states, it is working fine for me.

@abaldwin99
Copy link
Contributor Author

Yes! db6d41a works great for me!

@bryanjhv
Copy link
Owner

Thanks for the update. I also noticed a Cannot call method 'on' of null error with my extension after PR #4. The PR is right, but some things broke.
Sorry can't accept yours, but the Brackets API states the appReady method must be called, and accepting the changes means maybe in future releases another bug.

@abaldwin99
Copy link
Contributor Author

Makes sense to me. Sounds like #4 needs a debug. I just briefly looked at a couple other extensions and didn't see appReady called.

@bryanjhv
Copy link
Owner

Maybe you're right according to https://github.com/adobe/brackets/wiki/Brackets-Development-How-Tos#application-init . I'll still try your PR and make sure it works, ok? 😃

@bryanjhv bryanjhv merged commit a13f2aa into bryanjhv:master Jun 10, 2015
bryanjhv added a commit that referenced this pull request Jun 10, 2015
bryanjhv added a commit that referenced this pull request Jun 10, 2015
@bryanjhv
Copy link
Owner

It's now merged 😄 Thanks! There was a need to remove $ from globals comment, and the AppInit require, also some _getOption stuff instead of hardcoding CodeMirror.

@bryanjhv bryanjhv mentioned this pull request Jun 10, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants