feat(zoom-scroll): add zoom by cmd + wheel on mac #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi, Thanks for opening this PR. I've done some tests in the other applications to confirm that we follow users' expectations. Below are the results.
Based on above, I believe we should support CMD as an alternative key to trigger zoom scrolling. Thank you for implementing this! |
barmac
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for zooming using cmd on the mac platform
It is clear that zooming with ctrl + wheel is most likely a side effect, since event.ctrlKey is also a directive for pinch zoom. but since there is a feature, why not create a more pleasant UX on Mac