Add ability to render connections with round corners #747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
marstamm and
philippfromme
and removed request for
marstamm
+ render segmented connection as path
|
Very cool! I tried it out using the bpmn-js branch and found one weird behavior when merging bendpoints:
|
|
Thanks for the review. Will verify #747 (comment) and come back with this later. |
|
I'd ask you to check this out again. Works on my machine, but I had to update bpmn-io/bpmn-js#1828 to the latest commit on this branch.
|
marstamm
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Foundation for toolkits to build on top of this: