Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: align with alignment[type]=0 #740

Merged
merged 3 commits into from
Jan 19, 2023
Merged

fix: align with alignment[type]=0 #740

merged 3 commits into from
Jan 19, 2023

Conversation

YuJianghao
Copy link
Contributor

fix #739

@CLAassistant
Copy link

CLAassistant commented Jan 19, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@YuJianghao YuJianghao changed the title fix: align with alignment zero fix: align with alignment[type]=0 Jan 19, 2023
@nikku
Copy link
Member

nikku commented Jan 19, 2023

Great stuff. Could you also add a test case to verify alignment around 0?

@nikku nikku merged commit b2d3a7f into bpmn-io:develop Jan 19, 2023
@nikku
Copy link
Member

nikku commented Jan 19, 2023

Great stuff. Thanks for your contribution.

@YuJianghao YuJianghao deleted the fix_align branch January 19, 2023 10:37
nikku pushed a commit that referenced this pull request Feb 2, 2023
@YuJianghao @nikku
fix(modeling): correct alignment around 0|0 (#740)
7d3204d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikku nikku nikku left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alignment does not work with zero coord
3 participants
@YuJianghao @CLAassistant @nikku