Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(popup-menu): allow entries to be draggable #731

Merged
merged 4 commits into from
Jan 16, 2023
Merged

Conversation

smbea
Copy link
Contributor

@smbea smbea commented Jan 16, 2023

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jan 16, 2023
@smbea smbea requested review from a team, marstamm and barmac and removed request for a team January 16, 2023 10:20
@smbea smbea added in progress Currently worked on and removed needs review Review pending labels Jan 16, 2023
@smbea smbea requested a review from nikku January 16, 2023 13:13
@smbea smbea added needs review Review pending and removed in progress Currently worked on labels Jan 16, 2023
@nikku
Copy link
Member

nikku commented Jan 16, 2023

@smbea I've extracted the "complex" test case into an integration test. It should be easier now to verify if the stuff works end-to-end (and how it works). Just it.only on a single test and a UI test bed is up and running.

Going back to #731 (comment), did you validate the actual feel? Any odd behaviors you found?

Do we assume that click is always provided, or can there be cases where only dragstart is provided?

I do like that draggable is set implicitly.

@nikku
Copy link
Member

nikku commented Jan 16, 2023

Is there a concrete reason to not mirror the ContextPad behavior?

The end result should be a robust, predictable behavior for the user.

@smbea
Copy link
Contributor Author

smbea commented Jan 16, 2023

@nikku I had another look at it and we can in fact have an almost identical behaviour there - sorry for the back and forth! The one thing I kept different was having the default value "click" for the action. This way we don't introduce a breaking change to the trigger API

@barmac
Copy link
Member

barmac commented Jan 16, 2023

Looks good overall. I left a couple of comments which you can consider to implement but IMO the PR is mergable as is.

@nikku
Copy link
Member

nikku commented Jan 16, 2023

UI wise always making the entries draggable and later canceling the default is the more stable behavior; it prevents ugly artifacts (text selection) as seen in the capture below:

capture KlQ7Qa_optimized

I've updated the PR to that behavior (which we also have in context-pad, by the way).

@nikku nikku merged commit cd54e51 into develop Jan 16, 2023
@nikku nikku deleted the allow-draggability branch January 16, 2023 19:27
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants