Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modeling): remove incoming/outgoing on connection.delete #648

Merged
merged 2 commits into from
May 24, 2022
Merged

fix(modeling): remove incoming/outgoing on connection.delete #648

merged 2 commits into from
May 24, 2022

Conversation

marstamm
Copy link
Contributor

@marstamm marstamm requested review from nikku and a team May 24, 2022 12:13
@marstamm marstamm self-assigned this May 24, 2022
@marstamm marstamm requested review from MaxTru and removed request for a team May 24, 2022 12:13
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label May 24, 2022
@marstamm
Copy link
Contributor Author

Try with npx @bpmn-io/sr bpmn-io/bpmn-js#develop -l bpmn-io/diagram-js#remove-outgoing-connections

nikku
nikku requested changes May 24, 2022
View reviewed changes
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add one more test case

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels May 24, 2022
@marstamm marstamm requested a review from nikku May 24, 2022 13:04
@nikku nikku merged commit 40d6f21 into develop May 24, 2022
@nikku nikku deleted the remove-outgoing-connections branch May 24, 2022 13:42
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label May 24, 2022
@nikku
Copy link
Member

nikku commented May 24, 2022 •
edited
Loading

👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxTru MaxTru Awaiting requested review from MaxTru MaxTru was automatically assigned from bpmn-io/modeling-dev

@nikku nikku Awaiting requested review from nikku

Assignees

@marstamm marstamm

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marstamm @nikku