fix(core): ensure base layer has index 0 #585
Conversation
lib/features/resize/ResizeHandles.js
Outdated
| @@ -172,7 +174,7 @@ ResizeHandles.prototype.removeResizers = function() { | |||
| }; | |||
|
|
|||
| ResizeHandles.prototype._getResizersParent = function() { | |||
| return this._canvas.getLayer('resizers'); | |||
| return this._canvas.getLayer('resizers', LAYER_INDEX); | |||
There was a problem hiding this comment.
I don't like that change as it essentially means all special layers must explicitly render on top of the base layer.
What about the following:
- if no priority is given, layers render with priority 1
- base layers + plane layers render with the priority of
0
Please keep the canvas spec around. We should aim to fix this as part of our core.
There was a problem hiding this comment.
I don't like that change as it essentially means all special layers must explicitly render on top of the base layer.
This means: Breaking change for everyone who created layers in the past, bpmn-js, some extension we don't yet know about...
There was a problem hiding this comment.
Makes sense, we don't want a major release for this 👍
lib/features/resize/ResizeHandles.js
Outdated
| @@ -172,7 +174,7 @@ ResizeHandles.prototype.removeResizers = function() { | |||
| }; | |||
|
|
|||
| ResizeHandles.prototype._getResizersParent = function() { | |||
| return this._canvas.getLayer('resizers'); | |||
| return this._canvas.getLayer('resizers', LAYER_INDEX); | |||
There was a problem hiding this comment.
I don't like that change as it essentially means all special layers must explicitly render on top of the base layer.
This means: Breaking change for everyone who created layers in the past, bpmn-js, some extension we don't yet know about...
marstamm
force-pushed
the
fix-default-plane-position
branch
2 times, most recently
from
812d913
to
40ca9f5
Compare
|
Reverted the original bug (002d395) which gives us time to investigate this one in an orderly manner. |
bpmn-io-tasks
bot
added
in progress
marstamm
force-pushed
the
fix-default-plane-position
branch
from
40ca9f5
to
149ccb7
Compare
marstamm
force-pushed
the
fix-default-plane-position
branch
from
149ccb7
to
866dd8b
Compare
bpmn-io-tasks
bot
added
needs review
|
I've also double checked it against bpmn-js@latest and can confirm bpmn-io/bpmn-js#1520 is fixed and other things continue to work, too. |
This reverts commit 058731b and uses a positive index to place resize layers infront of rendered content
Why we need to revert:
Instead of lowering the index of planes, we should use the existing API to ensure our utility planes are rendered with priority