Activate tools immediately using last good known mouse event #511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
force-pushed
the
immediate-hand
branch
2 times, most recently
from
0ea287e
to
133f80c
Compare
* activate immediately on SPACE down using last mouse position * activate immediately on keyboard toggle using last mouse position Related to bpmn-io/bpmn-js#584
nikku
force-pushed
the
immediate-hand
branch
from
133f80c
to
2680b8b
Compare
bpmn-io-tasks
bot
added
needs review
|
Works for me. |
barmac
approved these changes
Dec 16, 2020
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A long standing UX issue in our toolkit is the fact that tool activation (hand tool, lasso tool, space tool, global connect tool) via keyboard shortcuts is wonky. Due to the fact that a mouse event is missing during keyboard activation actual visual feedback is only displayed after the first mouse move interaction.
A couple of related bugs have been filed in the past regarding this: #136, bpmn-io/bpmn-js#584, camunda/camunda-modeler#664, camunda/camunda-modeler#1229.
Since the rework of copy and paste (and the introduction of two-step copy and paste) we have the means to fix this issue: Automatically activate the tools using the last mouse position recorded by our
mousecomponent.This PR implements the described behavior for all tools.
Screen cast showing the improved behavior in action in bpmn-js
Closes #136