Align colors with Camunda Modeler #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oguzeroglu
changed the title
|
WIP because Andi needs to review this too. Code is ready for a review otherwise. |
oguzeroglu
force-pushed
the
476-color-alignment
branch
from
348ef8a
to
b0d967f
Compare
|
I set the definitions to .djs-container scope rather than root scope. |
oguzeroglu
changed the title
oguzeroglu
force-pushed
the
476-color-alignment
branch
from
478d38d
to
531d4e9
Compare
|
I modified the context pad hover color that Andi mentionned in his review. The rest is compatible with the v1 version of the designs. So we can merge this IMO. |
philippfromme
force-pushed
the
476-color-alignment
branch
from
531d4e9
to
15f397b
Compare
philippfromme
approved these changes
Jul 30, 2020
There was a problem hiding this comment.
According to the review we want to remove orange in favor of blue. I've gone ahead and did that as I had done it in my proposal.
I've also refactored the CSS variable names. I don't think that names like --gainsboro are very helpful. I have no idea what that is let alone that it's supposed to be a color.
* refactor color variable names * remove orange * fix visibility of bendpoint and segment dragger
philippfromme
force-pushed
the
476-color-alignment
branch
from
15f397b
to
c126ed4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #476