Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(copy-paste) Copy hidden and collapsed properties when copy-pasting. #441

Merged
merged 1 commit into from
Feb 7, 2020
Merged

fix(copy-paste) Copy hidden and collapsed properties when copy-pasting. #441

merged 1 commit into from
Feb 7, 2020

Conversation

yT0n1
Copy link
Contributor

@yT0n1 yT0n1 commented Jan 29, 2020

Addresses bpmn-io/bpmn-js#1270

Hidden and collapsed elements are now pasted correctly, however, three problems remain.

  1. The preview is not generated correctly.
  2. Labels are pasted incorrectly and are not visible. However, this bug appears to happen because the parent reference is not set correctly, similar to Labels are left visible when moved subprocess is collapsed bpmn-js#945. Because the label becomes the child of the root element, it is never unhidden, when its actual collapsed parent is expanded. This issue also happens by just collapsing, moving and uncollapsing a subprocess, unrelated to copy-pasting.
  3. After paste the sequence flow is selectable, however, once the root element has been selected, it is no longer selectable and correctly inside the actual parent shape.

pr

Please let me know which one of these bugs should be fixed in this PR and for which I should open additional issues. A pointer of where to fix 1 and 3 would also be welcome.

@claassistantio
Copy link

claassistantio commented Jan 29, 2020

CLA assistant check
All committers have signed the CLA.

@yT0n1 yT0n1 requested a review from nikku January 29, 2020 13:36
@nikku nikku merged commit 34a18b7 into bpmn-io:develop Feb 7, 2020
@nikku
Copy link
Member

nikku commented Feb 7, 2020

Thanks for your PR. I'll address the additional issues in a follow up PR.

@nikku nikku mentioned this pull request Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants