fix(graphics-factory): do not prepend to self #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
force-pushed
the
1129-fix-graphics-factory
branch
2 times, most recently
from
2b6ed0f
to
08da15a
Compare
philippfromme
changed the title
nikku
requested changes
Jul 17, 2019
lib/util/GraphicsUtil.js
Outdated
| */ | ||
| export function getChildren(gfx) { | ||
| return gfx.parentNode.childNodes[1]; | ||
| return domQuery('.djs-children', gfx.parentNode); |
There was a problem hiding this comment.
What is this good for? Is it part of the fix?
If not, can we undo this change?
philippfromme
force-pushed
the
1129-fix-graphics-factory
branch
from
08da15a
to
3c70235
Compare
nikku
approved these changes
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes bpmn-io/bpmn-js#1129
Related to bpmn-io/bpmn-js#746