Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

719 add minimum scale for context pad #282

Merged
merged 3 commits into from
Oct 8, 2018

Conversation

barmac
Copy link
Member

@barmac barmac commented Oct 8, 2018

This PR adds default minimum and maximum scale of ContextPad and allows to set scaling for ContextPad in config.

Closes #719

@ghost ghost assigned barmac Oct 8, 2018
@ghost ghost added the needs review Review pending label Oct 8, 2018
@nikku nikku self-requested a review October 8, 2018 07:01
@barmac barmac force-pushed the 719-add-minimum-scale-for-context-pad branch from 311baa4 to a22043e Compare October 8, 2018 07:20
barmac and others added 3 commits October 8, 2018 09:44
Make sure it not shrinks beyond 1.0.
* max line length
* spacing between specs
@nikku nikku force-pushed the 719-add-minimum-scale-for-context-pad branch from a22043e to 5977633 Compare October 8, 2018 07:46
@ghost ghost assigned nikku Oct 8, 2018
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a small commit improving the test styles.

Looks good to me!

@nikku nikku merged commit 12b6ea1 into master Oct 8, 2018
@ghost ghost removed the needs review Review pending label Oct 8, 2018
@delete-merged-branch delete-merged-branch bot deleted the 719-add-minimum-scale-for-context-pad branch October 8, 2018 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants