Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moving / adding waypoint shows attach feedback #382

Closed
1 task
nikku opened this issue Jul 15, 2019 · 1 comment · Fixed by #383
Closed
1 task

Moving / adding waypoint shows attach feedback #382

nikku opened this issue Jul 15, 2019 · 1 comment · Fixed by #383
Assignees
@nikku
Labels
bug Something isn't working modeling
Milestone
M29

Comments

@nikku
Copy link
Member

nikku commented Jul 15, 2019

Describe the Bug

Updating the connection waypoints shows the attach feedback since v4.0.0. This should not happen. Segment move does not show it, too.

capture qY1iZB_optimized

Steps to Reproduce

  • Draw a connection
  • Add or move bendpoint

Expected Behavior

  • Attach feedback is not shown (similar to parallel segment move)

Environment

Please complete the following information:

  • Browser: All
  • OS: All
  • Library version: v4.0.0
@nikku nikku added bug Something isn't working modeling labels Jul 15, 2019
@philippfromme philippfromme added the backlog Queued in backlog label Jul 15, 2019
nikku added a commit that referenced this issue Jul 15, 2019
@nikku
fix(bendpoints): do not show connect-{ok/not-ok} markers on move
054b259 
Closes #382
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Jul 15, 2019
@nikku nikku mentioned this issue Jul 15, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Jul 15, 2019
@nikku nikku added this to the M30 milestone Jul 15, 2019
nikku added a commit that referenced this issue Jul 16, 2019
@nikku
fix(bendpoints): do not show connect-{ok/not-ok} markers on move
9eaf350 
Closes #382
@nikku
Copy link
Member Author

nikku commented Jul 18, 2019

Closed via #383.

@nikku nikku closed this as completed Jul 18, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 18, 2019
nikku added a commit that referenced this issue Jul 18, 2019
@nikku
fix(bendpoints): do not show connect-{ok/not-ok} markers on move
52c03b6 
Closes #382
@nikku nikku modified the milestones: M30, M29 Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nikku nikku

Labels
bug Something isn't working modeling
Milestone
M29
Development

Successfully merging a pull request may close this issue.

Do not show connect allowed markers on bendpoint move bpmn-io/diagram-js
2 participants
@nikku @philippfromme