feat(popup-menu): add data-popup to container

This allows to style specific popup menu.
bpmn-io · Jun 27, 2022 · a9dd9ce · a9dd9ce
1 parent aa642c9
commit a9dd9ce
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 3 deletions.
diff --git a/lib/features/popup-menu/PopupMenu.js b/lib/features/popup-menu/PopupMenu.js
@@ -168,7 +168,7 @@ PopupMenu.prototype.open = function(element, id, position) {
 
   current.entries = assign({}, entries, headerEntries);
 
-  current.container = this._createContainer();
+  current.container = this._createContainer(id);
 
   if (size(headerEntries)) {
     current.container.appendChild(
@@ -354,7 +354,7 @@ PopupMenu.prototype._emit = function(eventName) {
  *
  * @return {Object} a DOM container
  */
-PopupMenu.prototype._createContainer = function() {
+PopupMenu.prototype._createContainer = function(id) {
   var container = domify('<div class="djs-popup">'),
       position = this._current.position,
       className = this._current.className;
@@ -368,6 +368,8 @@ PopupMenu.prototype._createContainer = function() {
 
   domClasses(container).add(className);
 
+  domAttr(container, 'data-popup', id);
+
   return container;
 };
 

diff --git a/test/spec/features/popup-menu/PopupMenuSpec.js b/test/spec/features/popup-menu/PopupMenuSpec.js
@@ -301,6 +301,18 @@ describe('features/popup', function() {
     }));
 
 
+    it('should add `data-popup` to popup menu container', inject(function(popupMenu) {
+
+      // when
+      popupMenu.open({}, 'menu', { x: 100, y: 100 });
+
+      // then
+      var container = getPopupContainer(popupMenu);
+
+      expect(container.dataset).to.have.property('popup', 'menu');
+    }));
+
+
     it('should throw error when no provider', inject(function(popupMenu) {
 
       // when not registering a provider
@@ -1456,5 +1468,9 @@ function queryEntry(popupMenu, id) {
 }
 
 function queryPopup(popupMenu, selector) {
-  return domQuery(selector, popupMenu._current.container);
+  return domQuery(selector, getPopupContainer(popupMenu));
+}
+
+function getPopupContainer(popupMenu) {
+  return popupMenu._current.container;
 }