Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad Hoc Collapsed Subprocess gets weird dimensions #1231

Closed
barmac opened this issue Nov 5, 2019 · 3 comments
Closed

Ad Hoc Collapsed Subprocess gets weird dimensions #1231

barmac opened this issue Nov 5, 2019 · 3 comments
Assignees
@philippfromme
Labels
bug Something isn't working good first issue Good for newcomers
Milestone
M32

Comments

@barmac
Copy link
Member

barmac commented Nov 5, 2019

Describe the Bug

ad-hoc

Steps to Reproduce

  1. Create an expanded Sub Process with a child element inside
  2. Collapse the Sub Process
  3. Turn the Sub Process into an Ad Hoc Sub Process

Expected Behavior

Dimensions don't change.

Environment

  • Browser: Chrome 78
  • OS: MacOS 10.14
  • Library version: demo.bpmn.io
@barmac
Copy link
Member Author

barmac commented Nov 5, 2019

This will be probably resolved as soon as we disallow collapsing non-empty Sub Process.

@nikku
Copy link
Member

nikku commented Nov 5, 2019 •
edited
Loading

This will not be resolved by disallowing collapsing via a plug-in, as it requires the plug-in to be fixed then.

🙊

@nikku nikku added backlog Queued in backlog bug Something isn't working good first issue Good for newcomers labels Nov 5, 2019
philippfromme added a commit to bpmn-io/diagram-js that referenced this issue Nov 14, 2019
@philippfromme
fix(replace): pass hints when moving children on replace
d12521b 
Related to bpmn-io/bpmn-js#1231
@philippfromme philippfromme mentioned this issue Nov 14, 2019
Merged
philippfromme added a commit that referenced this issue Nov 14, 2019
@philippfromme
fix(replace): do not resize on replace sub process with ad hoc
b441028 
Requires bpmn-io/diagram-js#432
Closes #1231
@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed backlog Queued in backlog labels Nov 14, 2019
@philippfromme philippfromme mentioned this issue Nov 14, 2019
Merged
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Nov 14, 2019
fake-join bot pushed a commit to bpmn-io/diagram-js that referenced this issue Nov 14, 2019
@philippfromme @fake-join
fix(replace): pass hints when moving children on replace
cda3686 
Related to bpmn-io/bpmn-js#1231
philippfromme added a commit that referenced this issue Nov 15, 2019
@philippfromme
fix(replace): do not resize on replace sub process with ad hoc
0a26184 
Requires bpmn-io/diagram-js#432
Closes #1231
barmac pushed a commit that referenced this issue Nov 15, 2019
@philippfromme @barmac
fix(replace): do not resize on replace sub process with ad hoc
dd3a139 
Requires bpmn-io/diagram-js#432
Closes #1231
@philippfromme
Copy link
Contributor

Closed via dd3a139

@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Nov 15, 2019
@nikku nikku added this to the M32 milestone Nov 15, 2019
oguzeroglu pushed a commit to bpmn-io/diagram-js that referenced this issue Mar 19, 2020
@philippfromme @oguzeroglu
fix(replace): pass hints when moving children on replace
e658614 
Related to bpmn-io/bpmn-js#1231
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philippfromme philippfromme

Labels
bug Something isn't working good first issue Good for newcomers
Milestone
M32
Development

No branches or pull requests
3 participants
@nikku @philippfromme @barmac