Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace React.PropTypes with PropTypes #83

Merged
merged 1 commit into from
Jul 24, 2017
Merged

Replace React.PropTypes with PropTypes #83

merged 1 commit into from
Jul 24, 2017

Conversation

ened
Copy link
Contributor

@ened ened commented May 15, 2017

@calebwoods
Copy link

Was going to submit a PR for this same fix. Would like to get the warnings removed. This PR would fix #86

@jeffvandyke
Copy link

This looks good to me as well, it's a pretty common and simple change in a lot of projects.

@hampusohlsson
Copy link

hampusohlsson commented Jun 27, 2017 •
edited
Loading

+1 @borisyankov would you consider merging?

@maxnowack
Copy link

@borisyankov please merge this :)

@michelegera
Copy link

I’d love to see this merged too. In the meantime, I am using @ened’s fork. 👍 🎩

@borisyankov
Copy link
Owner

Thanks for the contribution @ened

@borisyankov borisyankov merged commit e3add80 into borisyankov:master Jul 24, 2017
@hampusohlsson hampusohlsson mentioned this pull request Jul 27, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ened @calebwoods @jeffvandyke @hampusohlsson @maxnowack @michelegera @borisyankov