Correct error handling on exit when serving prometheus metrics #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for serving prometheus metrics was somewhat broken: It would attempt to check that the cancellation context didn't indicate that we should exit, but it would only do that _before_ starting to serve. Instead, we must serve, and if serve returns a fault, check whether we're meant to exit. Oops.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for serving prometheus metrics was somewhat broken: It would attempt to check that the cancellation context didn't indicate that we should exit, but it would only do that before starting to serve.
Instead, first serve, and if serve returns a fault, check whether we're meant to exit. Oops.