Fix a stale element re-selection bug #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tered out non-visible elements.
shermaneric
approved these changes
May 23, 2018
| //If elements were removed due to visibility then the list needs to be re-indexed. | ||
| filtered.forEach((elementFinder, i) => { | ||
| elementFinder.selectionOrdinal = i; | ||
| }); |
There was a problem hiding this comment.
Thanks for doing this one! We ran into this with one of our Ultra devs recently.
| appendStaleTestArea('second'); | ||
|
|
||
| expect(el.hasClass('second')).toEqual(true); | ||
| })); |
There was a problem hiding this comment.
So I may be overthinking this one. I see what the test is doing here and it looks good!
( Re-adding the .second class and verifying that the element contains it. )
What I'm not sure about is when I add this protractor_sync_test.ts file back to my local develop, I'm expecting the test to fail (pre selection.ts change above) but it's succeeding.
I've cleaned the build and re-ran the build. Not sure if I'm missing something.
Thanks!
EDIT: Never mind the above, I didn't have the test spec file in the right spot. I was able to recreate the test error earlier. Approving.
mindywhitsitt
approved these changes
May 23, 2018
|
Fire when ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue with re-selecting a stale element when the selection filtered out non-visible elements.