Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect comparison in runpayload method #1108

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Conversation

Reset816
Copy link
Contributor

Description

This pull request addresses an issue in the runpayload method where the if statement was incorrectly comparing the acknowledgement value with itself, which always returns true. The comparison has been corrected to properly compare the response acknowledgement (response_ack) with the expected ack value.

Changes Made

  • Corrected the if statement from if ack == ack: to if response_ack == ack:.

Corrected the if statement to properly compare the response_ack with the expected ack value.
@Reset816
Copy link
Contributor Author

This is a great project! It saved my phone, and I am very grateful for the author's contribution.

I still have some unclear points regarding the principles. For instance, what are da1 and da2 respectively? Are they the download agent for bootrom and the download agent for the preloader? And what is stage2?

@bkerler
Copy link
Owner

bkerler commented Jul 22, 2024

Thanks ! That's a really weird code .. need to dig into when that happened. DA1 is the first stage, similar to preloader, whereas DA2 is the second stage, similar to little kernel.

@bkerler bkerler merged commit 554b963 into bkerler:main Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants