This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Iterate through pages returned by List Your Organizations endpoint #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlhendy
reviewed
Nov 20, 2017
providers/github.go
Outdated
| @@ -61,36 +62,45 @@ func (p *GitHubProvider) hasOrg(accessToken string) (bool, error) { | |||
| Login string `json:"login"` | |||
| } | |||
|
|
|||
| params := url.Values{ | |||
| "limit": {"100"}, | |||
| var orgs_page []struct { | |||
There was a problem hiding this comment.
Comment on naming, in go we typically use camel case/mixed caps rather than underscores - so I'd update this to orgsPage and page_number to pageNum.
For some GHE instances where a user can have more than 100 organizations, traversing the other pages is important otherwise oauth2_proxy will consider the user unauthorized. This change traverses the list returned by the API to avoid that. Update github provider tests to include this case.
|
@hlhendy update this PR based on the last set of comments and made some slight updates to the logic. Also included some tests. RFR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PREAMBLE: This PR leaves much to be desired at the time of submission.
I'm submitting it anyway to get early feedback. I'm also still ramping up
on my golang-fu so please excuse the dust.
=====
For some GHE instances where a user can have more than 100
organizations, traversing the other pages is important otherwise
oauth2_proxy will consider the user unauthorized. This change traverses
the list returned by the API to avoid that.