feat: replace variable picker dropdown #2344 #2787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces uses of https://github.com/zurb/tribute which looks like it might no longer be maintained, and is not very react friendly with some custom wrapping around react-select, which we already use for simple dropdown fields.
This makes the ui a bit more consistent, as it matches the look of elsewhere, and avoids the bug of #2344 by locking the dropdown to always be below the text field, and to always be the full width
It is possible that there are some unintentional quirks in this new implementation, as some of the features of react-select have to be bypassed, and some functionality you would expect from this kind of 'suggestion' input have to be implemented around what react-select offers.
But as a bonus of this, we have a bit more control over some of the behaviour, which resolves some existing quirks around the picker not opening if there is not a space in front of the
$(sequence.