Bump MSRV to Rust 1.48.0 #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The pinning isn't working, I'll try again later with fresh eyes. EDIT: ha, I was using the wrong version number. Pinning works in CI now. |
Recently the `rust-bitcoin` org bumped their MSRV to Rust 1.48, we can do the same here. `serde` v1.0.157 uses syn 2.0 which is edition 2021 so cannot be built with 1.48 - we need to pin `serde` to v1.0.156 We can remove all the other pinning, features, and dependencies that were required to get 1.41.1 to build.
This was referenced Jun 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the
rust-bitcoinorg bumped their MSRV to Rust 1.48, we can do the same here.serdev1.0.157 uses syn 2.0 which is edition 2021 so cannot be built with 1.48 (same foronce_cell) - we need to pinserdeto v1.0.156 andonce_cellto v1.14We can remove all the other pinning, features, and dependencies that were required to get 1.41.1 to build.
Fix: #79