-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ci #16
Add ci #16
Conversation
This commit fixes bitcoindevkit#15
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 20f2444
Looks good to me! Can't really test if it works properly, so I'll just go ahead and merge it, and if it's broken somehow we'll fix it :)
Also, nit for the future: commit title should start with a capital letter ("Add workflow"), and you should put in the commit description the issue that it's closing/partially fixing if there's one :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While merging I actually noticed there are some trailing whitespaces, can you remove them?
Noted. Will remember it in the future. |
Since I've delayed the merge anyways, can you fix in these PR as well? :) |
It works on my fork, so it should work here as well. Otherwise it would be weird indeed XD. |
Ah ok, cool :) re-utACK e95bcc7 |
Branched after PR #13.
Includes tests for: