Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ci #16

Merged
merged 1 commit into from
May 15, 2022
Merged

Add ci #16

merged 1 commit into from
May 15, 2022

Conversation

wszdexdrf
Copy link
Contributor

Branched after PR #13.

Includes tests for:

  • cargo build
  • cargo clippy
  • cargo test using docker image containing Trezor emulator

This commit fixes bitcoindevkit#15
Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 20f2444

Looks good to me! Can't really test if it works properly, so I'll just go ahead and merge it, and if it's broken somehow we'll fix it :)

Also, nit for the future: commit title should start with a capital letter ("Add workflow"), and you should put in the commit description the issue that it's closing/partially fixing if there's one :)

Copy link
Member

@danielabrozzoni danielabrozzoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While merging I actually noticed there are some trailing whitespaces, can you remove them?

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
@wszdexdrf
Copy link
Contributor Author

wszdexdrf commented May 15, 2022

Also, nit for the future: commit title should start with a capital letter ("Add workflow"), and you should put in the commit description the issue that it's closing/partially fixing if there's one :)

Noted. Will remember it in the future.

@danielabrozzoni
Copy link
Member

Since I've delayed the merge anyways, can you fix in these PR as well? :)

@wszdexdrf
Copy link
Contributor Author

Can't really test if it works properly, so I'll just go ahead and merge it, and if it's broken somehow we'll fix it :)

It works on my fork, so it should work here as well. Otherwise it would be weird indeed XD.

@danielabrozzoni
Copy link
Member

danielabrozzoni commented May 15, 2022

Ah ok, cool :)

re-utACK e95bcc7

@danielabrozzoni danielabrozzoni merged commit ebb1b1c into bitcoindevkit:master May 15, 2022
@wszdexdrf wszdexdrf deleted the add_ci branch May 21, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants