Enabled tf bech32m-encode #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The Tapscript example does not produce the bech32 address that I expected.
Cause
The Tapscript example uses bech32 instead of bech32m. I believe that most systems will expect bech32m for Tapscript.
Solution
I enabled bech32m-encode.
If my assumptions about tapscript and bech32m hold true, and if this PR gets merged, I may have time to update the example to include bech32m-encodings.
Bech32m vs bech32
bech32m result: bcrt1p7y52329xxmse7q9gq9542rldlsntdawaqnvntmz99z224kfcauxqag4w9y
bech32 result: bcrt1p7y52329xxmse7q9gq9542rldlsntdawaqnvntmz99z224kfcauxqg59zqx