Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar URL check - controlling response code #2916

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Avatar URL check - controlling response code #2916

merged 1 commit into from
Sep 28, 2021

Conversation

hiroshisuga
Copy link
Contributor

Description

This change fixes a "broken image icon" shown in BBB as an avatar when the URL turns out to be unreachable.

Testing Steps

  1. Put a truncated URL in the user profile pic, simulating the situation where the image in the Internet has been deleted.
  2. Start BBB meeting, and you will see the "broken image icon" as the avatar. We may want the default alphabet icon in this case.
  3. With this PR, BBB shows the default avatar with the starting two letters of your account name

@sonarcloud
Copy link

sonarcloud bot commented Sep 27, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@farhatahmad farhatahmad merged commit 6e804d5 into bigbluebutton:master Sep 28, 2021
wbonis pushed a commit to styliteag/greenlight that referenced this pull request Dec 15, 2021
@hiroshisuga @wbonis
response code must be 200 (bigbluebutton#2916)
48969f1
thifranc pushed a commit to thifranc/greenlight that referenced this pull request Dec 27, 2021
@hiroshisuga
response code must be 200 (bigbluebutton#2916)
4988b71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@farhatahmad farhatahmad farhatahmad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hiroshisuga @farhatahmad