Accessibility fix generate access code #2783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
Thanks for all the PRs @galupa. I'll get through them all sometime this week |
farhatahmad
reviewed
Sep 18, 2021
| @@ -50,6 +50,36 @@ $(document).on('turbolinks:load', function(){ | |||
| showDeleteRoom(this) | |||
| }) | |||
|
|
|||
| // For keyboard users to be able to generate access code | |||
There was a problem hiding this comment.
Same as for the other PR - can this be moved into a separate function?
There was a problem hiding this comment.
Sure, thanks for reviewing the codes, I have made the changes, please check it again when you have time
tidy up code based on CR
galupa
force-pushed
the
accessibility-fix-generate-access-code
branch
from
d3c9399
to
32f6e4e
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
farhatahmad
approved these changes
Sep 28, 2021
wbonis
pushed a commit
to styliteag/greenlight
that referenced
this pull request
Dec 15, 2021
…#2783) tidy up code based on CR Co-authored-by: Rangga Permana <[email protected]>
thifranc
pushed a commit
to thifranc/greenlight
that referenced
this pull request
Dec 27, 2021
…#2783) tidy up code based on CR Co-authored-by: Rangga Permana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should enable keyboard users to be able to generate or reset access codes. It also enable users with visual impairment to know what the generated code is.
Description
The changes on this PR are as follows:
Testing Steps
To test this:
Screenshots (if appropriate):
Not much changes on UI, but the buttons / icon should be able to be selected by only using keyboard
