Fix broken UI on long filenames #2215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you select a presentation with a very long filename in in Greenlight, the filename text in the upload dialog wraps at the end and leaves the label box, leading to a slightly broken looking user interface. This patch adjusts the style to hide the end of a long filename, ending with a horizontal ellipsis instead.
farhatahmad
approved these changes
Oct 21, 2020
galupa
pushed a commit
to galupa/greenlight
that referenced
this pull request
Jun 29, 2021
If you select a presentation with a very long filename in in Greenlight, the filename text in the upload dialog wraps at the end and leaves the label box, leading to a slightly broken looking user interface. This patch adjusts the style to hide the end of a long filename, ending with a horizontal ellipsis instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you select a presentation with a very long filename in in Greenlight,
the filename text in the upload dialog wraps at the end and leaves the
label box, leading to a slightly broken looking user interface.
This patch adjusts the style to hide the end of a long filename, ending
with a horizontal ellipsis instead.
Before:
Fixed:
