Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed exported file name to index.mjs #19

Merged
merged 5 commits into from
Nov 23, 2023
Merged

Changed exported file name to index.mjs #19

merged 5 commits into from
Nov 23, 2023

Conversation

Amaljith-K
Copy link
Contributor

This will fix the following problem while building jsdocs in neeto-molecules

import { matches } from "@bigbinary/neeto-cist";
^^^^^^^
SyntaxError: Named export 'matches' not found. The requested module '@bigbinary/neeto-cist' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@bigbinary/neeto-cist';
const { matches } = pkg;

Checklist

  • I have made corresponding changes to the documentation
  • I have verified the generated JSDoc comments
  • I have updated the types definition of modified exports
  • I have added jest tests for newly added changes
  • I have verified the functionality in some of the neeto web-apps.

@ajmaln _a
cc @josephmathew900

@Amaljith-K
Copy link
Contributor Author

@ajmaln and @josephmathew900 JSDoc generation is broken in neeto-molecules since https://github.com/bigbinary/neeto-molecules/pull/787 because of some major upgrades to some packages like unified.

@anmol-kumar0815 @CalvinChiramal why didn't you guys notice this error when running yarn bundle?
Or haven't you tested it at all?

image

@CalvinChiramal
Copy link

@Amaljith-K This error did not come up locally when I ran yarn bundle and even the PR app got deployed without any issues. I had only assigned for review after that.
I could only recreate this locally yesterday when I deleted the node_modules folder and ran yarn bundle again. I had not tested it by deleting node_modules and since the PR app got deployed I expected that everything was fine.

@ajmaln ajmaln added the patch Releases small requests or bug fixes. label Nov 23, 2023
@ajmaln ajmaln merged commit aaac287 into main Nov 23, 2023
1 check failed
@anmol-kumar0815
Copy link

@Amaljith-K I also did not encounter this error locally. The only error I faced was when running the Storybook, and later, I found the solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Releases small requests or bug fixes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants