Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPS support #240

Merged
merged 5 commits into from
Sep 13, 2016
Merged

HTTPS support #240

merged 5 commits into from
Sep 13, 2016

Conversation

mvdbeek
Copy link
Contributor

@mvdbeek mvdbeek commented Sep 13, 2016

To use a self-signed certificate and HTTPS, start with -e USE_HTTPS=True.
If you have your own certificates, copy them to /export/{server.key,server.crt}.
If you want to use letsencrypt, start with -e USE_HTTPS_LETSENCRYPT=True -e GALAXY_CONFIG_GALAXY_INFRASTRUCTURE_URL =<your_domain>.

If you use HTTPS, you also need to make sure port 443 is available.
@zfrenchee can you add the more extended documentation you had in galaxyproject/ansible-galaxy-extras#103 ?

@bgruening
Copy link
Owner

@mvdbeek we could enable https with self-signed certs by default. Any objections?

@mvdbeek
Copy link
Contributor Author

mvdbeek commented Sep 13, 2016

Yes, we have no access to port 443 on the IFB cloud, but if we don't forward 80 to 443 people can still leak their credentials.

@mvdbeek
Copy link
Contributor Author

mvdbeek commented Sep 13, 2016

Also for dev purposes a self-signed cert is very annoying, you'll constantly have to turn off verification (bioblend, requests, etc).

@bgruening
Copy link
Owner

Ok, thats sad but a valid reason :)

@mvdbeek
Copy link
Contributor Author

mvdbeek commented Sep 13, 2016

It's a pretty selfish reason though, there's no real problem to to say USE_HTTPS=False ...

@bgruening
Copy link
Owner

I trust @zfrenchee to update the docs after the merge.
Thanks a lot for all the work!

@bgruening bgruening merged commit 254255f into bgruening:dev Sep 13, 2016
@alexlenail
Copy link
Contributor

@bgruening I'm happy to -- would you be against a gh-pages branch to make a pretty website with docs for this project? I think that would be better.

@bgruening
Copy link
Owner

gh-pages are not needed anymore. Actually my plan was to use the new doc feature and convert the readme automatically to a webpage like @bebatut did here: https://github.com/bgruening/training-material
No time until know :(

@alexlenail
Copy link
Contributor

That's what github pages is! We had the same idea!

On Sun, Sep 18, 2016 at 6:52 AM, Björn Grüning [email protected]
wrote:

gh-pages are not needed anymore. Actually my plan was to use the new doc
feature and convert the readme automatically to a webpage like @bebatut
https://github.com/bebatut did here: https://github.com/bgruening/
training-material
No time until know :(


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#240 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ACojfaGOm4NeyqcfkZPo8G6P229K4VQsks5qrRgIgaJpZM4J7nO-
.

Alex Lenail
Tufts University '16

@bgruening
Copy link
Owner

@zfrenchee as it seems you have not updated the docs! ;)

@alexlenail
Copy link
Contributor

alexlenail commented May 8, 2017

@bgruening sorry! Want me to update the README or create a new page under docs/?

@bgruening
Copy link
Owner

@zfrenchee readme would be fantastic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants