Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version traduite du simulateur #188

Merged
merged 69 commits into from
Apr 12, 2018
Merged

Version traduite du simulateur #188

merged 69 commits into from
Apr 12, 2018

Conversation

Morendil
Copy link
Contributor

@Morendil Morendil commented Mar 20, 2018

Il manque:

  • un mécanisme pour changer dynamiquement de langue
  • traduction du titre de la question du salaire, la question est dans le mécanisme "inversion"
  • le placeholder "votre réponse"
  • traduction de Oui et Non, probablement dans Input.js ou generateQuestions.js
  • les suggestions

Pour la grille de niveau 2:

  • ses branches
  • les noms des 3 salaires, probablement réécrits en dur
  • les noms des cotisations à traduire

🔺 Attention
La traduction de la question d'inversion est assez sauvage, à fixer. De toute façon, #163 devrait la supprimer.

🔺
La traduction de la grille de niveau 2 est légèrement dénormalisée: on utilise bien la traduction de la base pour les lignes de détail, mais les noms des branches et des éléments du salaires sont retraduits dans le fichier YAML de traduction de l'UI.

@Morendil Morendil temporarily deployed to syso-pr-188 March 20, 2018 17:01 Inactive
@laem laem temporarily deployed to syso-pr-188 March 26, 2018 13:40 Inactive
@laem laem temporarily deployed to syso-pr-188 March 27, 2018 08:52 Inactive
@laem laem temporarily deployed to syso-pr-188 March 27, 2018 11:40 Inactive
@laem laem temporarily deployed to syso-pr-188 March 27, 2018 11:49 Inactive
@laem laem temporarily deployed to syso-pr-188 March 27, 2018 11:57 Inactive
@Morendil Morendil temporarily deployed to syso-pr-188 March 27, 2018 12:24 Inactive
@laem laem temporarily deployed to syso-pr-188 March 27, 2018 13:54 Inactive
@laem laem temporarily deployed to syso-pr-188 March 27, 2018 14:00 Inactive
@laem laem temporarily deployed to syso-pr-188 March 27, 2018 14:02 Inactive
@Morendil Morendil temporarily deployed to syso-pr-188 March 27, 2018 16:56 Inactive
@Morendil Morendil temporarily deployed to syso-pr-188 March 27, 2018 19:46 Inactive
@Morendil Morendil temporarily deployed to syso-pr-188 March 27, 2018 20:01 Inactive
@laem laem temporarily deployed to syso-pr-188 April 9, 2018 09:43 Inactive
@Morendil
Copy link
Contributor Author

Morendil commented Apr 10, 2018

Dans la vue détaillée, traduire encore:

  • "Logement"
  • "Réductions"

@etienneCharignon
Copy link
Member

J'ai vu qu'il manquait aussi la traduction du bouton "envoyer" (avec l'envelope) à la fin du formulaire de retour.

@laem laem temporarily deployed to syso-pr-188 April 10, 2018 14:00 Inactive
I had to force the default language to a value (I forced it to 'fr') so
that the fr resource is effectively loaded in the first place
You must not decorate decorator with @translate(). Only final classes have to
be decorated.

for the same reason, the order of decorator declaration in final classes is
important and @translate must be in last position (juste before the class
declaration)
@laem laem temporarily deployed to syso-pr-188 April 12, 2018 09:35 Inactive
@laem
Copy link
Contributor

laem commented Apr 12, 2018

Intégration des PR #194 et #195 , merci Etienne !

@laem laem temporarily deployed to syso-pr-188 April 12, 2018 09:44 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants