Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign #163

Closed
wants to merge 82 commits into from
Closed
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
82 commits
Select commit Hold shift + click to select a range
1cdd3d1
Ajout du Ctrl-P pour rechercher une règle
laem Jan 30, 2018
b411d1b
:sparkles: :gear: plus de double négation
laem Feb 1, 2018
016c029
:sparkles: chokidar est une dépendance inutilisée
laem Feb 6, 2018
d87ffc1
Plus de confusion entre le salaire de base et le salaire brut
laem Feb 1, 2018
b23e3f3
:sparkles: Simplification du code de génération de questions
laem Feb 6, 2018
cc2fe2c
Simplification gen qestions (2)
laem Feb 6, 2018
538196f
Simplification gen questions (3)
laem Feb 6, 2018
1103660
:bug: On peut maintenant passer une question pendant la saisie numérique
laem Feb 6, 2018
f7dd5e2
:art: Déroulement plus doux des questions
laem Feb 6, 2018
929ef0c
:memo: Documentation de la fonction getInputComponent
laem Feb 7, 2018
1c4740d
Création du RadioInpu
laem Feb 7, 2018
c627f2b
Ebauche de nouveau composant pour la saisie salaire
laem Feb 7, 2018
aa69234
Nouveau composant saisie salaire (2)
laem Feb 7, 2018
212e026
Nouveau composant saisie salaire (3)
laem Feb 8, 2018
688424a
Nouveau composant saisie salaire (4)
laem Feb 8, 2018
54eee25
Nouveau composant saisie salaire (5)
laem Feb 8, 2018
03ef755
Les types de salaires sont explicables
laem Feb 8, 2018
ea2bb17
:hammer: Vrai définition du salaire brut
laem Feb 8, 2018
cdcca5d
Amélioration des textes d'objectifs
laem Feb 8, 2018
0721890
:sparkles: Refactorisation de code
laem Feb 13, 2018
e906227
Simplification du texte de changement d'objectifs
laem Feb 13, 2018
bc9fb0f
Amélioration de la description des salaires
laem Feb 13, 2018
b1d2291
Déplacement de la saisie salaire entre les inversions possibles
laem Feb 13, 2018
da45955
Ajout d'un brouillon de nouvel icône 'Aide'
laem Feb 13, 2018
cf88597
Estimer, pas calculer
laem Feb 26, 2018
0634c1f
Le message de mise a jour a fait son temps
laem Feb 26, 2018
d88ceec
Revision des resume des salaires
laem Feb 26, 2018
800ef4c
Brouillon de nouveau design pour l'accueil
laem Feb 28, 2018
050ad0c
:art: Agencement basique de la saisie des objectifs
laem Mar 1, 2018
948a6b0
Etape d'affinage des objectifs
laem Mar 1, 2018
6f6e431
Premiere version, moche, de la nouvelle selection du salaire
laem Mar 1, 2018
5a84493
:sparkles: Nettoyage de la configuration Webpack
laem Mar 1, 2018
a32a6a7
:arrow_up: Migration vers webpack 4
laem Mar 1, 2018
3a8b674
:racehorse: Compilation plus rapide en dev
laem Mar 7, 2018
41ccd11
:art: Design plein bleu pour l'ecran d'accueil
laem Mar 7, 2018
6f38950
Retour a une formulation plus directe de la question de salaire
laem Feb 13, 2018
abc752f
:art: Amélioration visuelle des radios d'inversion
laem Feb 13, 2018
b3f46c0
:fire: Composant inutile
laem Mar 12, 2018
64fcec7
JSON pour le prettierrc
laem Mar 12, 2018
7ff06e2
Modification du state pour le nouveau design
laem Mar 12, 2018
f1e0636
Compilation sur Webpack 4
laem Mar 12, 2018
daca8e8
Interactions sur TargetSelection
laem Mar 12, 2018
462d369
Mise a jour de yarn.lock
laem Mar 12, 2018
c1ceac0
Amelioration des messages guides
laem Mar 14, 2018
a1e46bd
Barre de progression plus visible
laem Mar 14, 2018
a1c53ba
Deplacement des reponses en haut
laem Mar 14, 2018
758a4f8
Tentative de :art
laem Mar 14, 2018
c44bc24
Inversion de l'ordre des salaires
laem Mar 15, 2018
a435798
Travail sur l'agencement des blocs
laem Mar 15, 2018
ffc2d5c
:arrow_up: Mise a jour des paquets
laem Mar 15, 2018
0ca320c
Simplification du package.json
laem Mar 15, 2018
9e3598c
:sparkles: Simplification du webpack de test
laem Mar 15, 2018
bd367c7
Ajout de questions aux variables de salaire
laem Mar 19, 2018
84aea72
Affichage du champ de saisie seulement s'il y a une question
laem Mar 19, 2018
8ad7438
Affichage de l'unite euros sur tous les champs
laem Mar 19, 2018
241f5f4
:art: Style des champs de saisie de salaire
laem Mar 19, 2018
005d712
:doc: Amelioration de la documentation de l'inversion
laem Mar 19, 2018
7dd248a
Recherche de regle plus accessible
laem Mar 19, 2018
28c670e
:up_arrow: MAJ des dependances
laem Mar 19, 2018
7dd7e35
:up_arrow: MAJ version node
laem Mar 19, 2018
62d92b5
:sparkles: Nettoyage de TargetSelection
laem Mar 21, 2018
08a5721
Amelioration de la validation des saisies
laem Mar 21, 2018
b67583a
Fix crash when erasing value
Morendil Mar 21, 2018
2807cef
:bug: typo dans le CSS et attribut inutile
laem Mar 21, 2018
e9b0752
:bug: Changement de salaire saisi fonctionnel...
laem Mar 21, 2018
da24674
:up-arrow: MAJ mocha-webpack
laem Mar 22, 2018
90eadbc
La valeur calculee d'un salaire initialise la saisie
laem Mar 22, 2018
99b502a
:gear: Améliore ResultsGrid
Morendil Mar 22, 2018
27bd207
Plus d'URL de simulation
laem Mar 22, 2018
23372df
:fire: Actions obsoletes
laem Mar 22, 2018
10b6149
Stockage des objectifs selectionnes
laem Mar 22, 2018
f727412
:art: Design des objectifs
laem Mar 22, 2018
8381bf6
:art: Alignement et augmentation de la police WIP
laem Mar 22, 2018
84ce5c4
:art: Ajout d'un titre a l'icone de recherche
laem Mar 29, 2018
049b425
:hammer: Ajout d'une description aux aides differees
laem Mar 29, 2018
4ebd4a9
Les objectifs de calcul sont des liens
laem Mar 29, 2018
6ebdba9
:hammer: Clarification du resume de Aides employeur
laem Mar 29, 2018
7605fd9
Mise en valeur de la temporalite mensuelle
laem Mar 29, 2018
2247fd0
Revue des textes de guidage
laem Mar 29, 2018
4a4af14
Pas d'autofocus sur les etapes de saisie
laem Apr 3, 2018
f09eeea
:hammer: Reformulation des titres de salaire
laem Apr 3, 2018
d274e2d
Mise en evidence du caractere approximatif
laem Apr 3, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Stockage des objectifs selectionnes
  • Loading branch information
laem committed Apr 12, 2018
commit 10b61494ebd593766e03ede14033f097622f8445
10 changes: 5 additions & 5 deletions source/components/ProgressTip.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ import { Line } from 'rc-progress'
@connect(state => ({
foldedSteps: state.foldedSteps,
nextSteps: state.nextSteps,
colour: state.themeColours.colour
colour: state.themeColours.colour,
conversationTargetNames: state.conversationTargetNames
}))
export default class ProgressTip extends Component {
render() {
Expand All @@ -17,16 +18,15 @@ export default class ProgressTip extends Component {
nextSteps,
foldedSteps,
colour,
conversationVisible,
selectingTargets
conversationTargetNames
} = this.props,
nbQuestions = nextSteps.length

if (selectingTargets && !conversationVisible)
if (conversationTargetNames && conversationTargetNames.length === 0)
return nbQuestions ? (
<p>Vous aurez {nextSteps.length} questions !</p>
) : null
if (!conversationVisible) return null
if (!conversationTargetNames) return null
return (
nbQuestions != 0 && (
<div className="progressTip">
Expand Down
25 changes: 4 additions & 21 deletions source/components/Simu.js
Original file line number Diff line number Diff line change
Expand Up @@ -9,34 +9,17 @@ import Explanation from './Explanation'

@withColours
export default class extends Component {
state = {
conversationVisible: false,
selectingTargets: false
}
render() {
let { colours } = this.props,
{ selectingTargets, conversationVisible } = this.state
let { colours } = this.props

return (
<div>
<FoldedSteps />
<div id="focusZone">
<GoToAnswers />
<TargetSelection
colours={colours}
conversationVisible={this.state.conversationVisible}
showConversation={() =>
this.setState({ conversationVisible: true })
}
selectingTargets={selectingTargets}
setSelectingTargets={() =>
this.setState({ selectingTargets: true })
}
/>
<ProgressTip {...{ selectingTargets, conversationVisible }} />
{this.state.conversationVisible && (
<Conversation textColourOnWhite={colours.textColourOnWhite} />
)}
<TargetSelection colours={colours} />
<ProgressTip />
<Conversation textColourOnWhite={colours.textColourOnWhite} />
<Explanation />
</div>
</div>
Expand Down
15 changes: 7 additions & 8 deletions source/components/TargetSelection.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,8 @@ export default class TargetSelection extends Component {
}

render() {
this.firstEstimationComplete =
this.state.activeInput && this.props.targets.length > 0
let { targets, conversationTargetNames } = this.props
this.firstEstimationComplete = this.state.activeInput && targets.length > 0
return (
<div id="targetSelection">
{!this.firstEstimationComplete && <h1>Entrez un salaire mensuel</h1>}
Expand All @@ -54,16 +54,16 @@ export default class TargetSelection extends Component {

{this.firstEstimationComplete && (
<div id="action">
{this.props.selectingTargets ? (
!this.props.conversationVisible && (
{conversationTargetNames ? (
!conversationTargetNames.length && (
<p>Que voulez-vous affiner ?</p>
)
) : (
<>
<p>Estimation par défaut pour un CDI non cadre ... </p>
<BlueButton
onClick={() => {
this.props.setSelectingTargets()
this.props.setConversationTargets([])
}}
>
Personnaliser
Expand All @@ -85,7 +85,7 @@ export default class TargetSelection extends Component {
} = this.props,
optionIsChecked = s => (conversationTargetNames || []).includes(s.name),
visibleCheckbox = s =>
this.props.selectingTargets && s.dottedName !== this.state.activeInput,
conversationTargetNames && s.dottedName !== this.state.activeInput,
toggleTarget = target =>
ifElse(contains(target), without(target), append(target))

Expand All @@ -100,11 +100,10 @@ export default class TargetSelection extends Component {
id={s.name}
type="checkbox"
checked={optionIsChecked(s)}
onClick={() => this.props.showConversation()}
onChange={() =>
setConversationTargets(
toggleTarget(s.name)(
conversationTargetNames.filter(
(conversationTargetNames || []).filter(
t => !this.state.activeInput.includes(t)
)
)
Expand Down
7 changes: 5 additions & 2 deletions source/components/conversation/Conversation.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ import './conversation.css'
done: state.done,
nextSteps: state.nextSteps,
analysis: state.analysis,
parsedRules: state.parsedRules
parsedRules: state.parsedRules,
conversationTargetNames: state.conversationTargetNames
}),
dispatch => ({
reinitialise: () => {
Expand All @@ -39,8 +40,10 @@ export default class Conversation extends Component {
parsedRules,
targetNames,
reinitialise,
textColourOnWhite
textColourOnWhite,
conversationTargetNames
} = this.props
if ((conversationTargetNames || []).length === 0) return null
return (
<>
<div id="currentQuestion">
Expand Down
1 change: 0 additions & 1 deletion source/containers/App.dev.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export default ({ store }) => (
<Provider store={store}>
<div id="dev">
<Layout />
<DevTools />
</div>
</Provider>
)
2 changes: 1 addition & 1 deletion source/reducers.js
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ export default reduceReducers(
analysis: (state = null) => state,

targetNames: (state = popularTargetNames) => state,
conversationTargetNames: (state = []) => state,
conversationTargetNames: (state = null) => state,

situationGate: (state = name => null) => state,

Expand Down