Skip to content
This repository has been archived by the owner on Aug 22, 2023. It is now read-only.

fix: fixed susbcriber for invokable controllers #73

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

vitsadecky
Copy link

@vitsadecky vitsadecky commented Feb 26, 2020

fixed for invokable controller and shorten routing definition:
symfony-invokable controllers

dont work before this MR:
customer_promotional_voucher_list:
path: /promotional-vouchers
controller: App\Controller\Customer\Voucher\PromotionalVoucherListControlle

work only
path: /promotional-vouchers
controller: App\Controller\Customer\Voucher\PromotionalVoucherListController::__invoke

@coveralls
Copy link

Pull Request Test Coverage Report for Build 185

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.007%) to 99.165%

Files with Coverage Reduction New Missed Lines %
src/Listener/AnnotationSubscriber.php 1 95.24%
Totals Coverage Status
Change from base Build 183: 0.007%
Covered Lines: 475
Relevant Lines: 479

💛 - Coveralls

@coveralls
Copy link

coveralls commented Feb 26, 2020

Pull Request Test Coverage Report for Build 185

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.005%) to 99.163%

Files with Coverage Reduction New Missed Lines %
src/Listener/AnnotationSubscriber.php 1 95.24%
Totals Coverage Status
Change from base Build 183: 0.005%
Covered Lines: 474
Relevant Lines: 478

💛 - Coveralls

Copy link
Contributor

@migo315 migo315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks fine for me. This fix #72.

@migo315 migo315 merged commit 48ce03d into bestit:master Feb 26, 2020
@migo315
Copy link
Contributor

migo315 commented Feb 26, 2020

I will release it as 4.0.1 tomorrow.

@migo315 migo315 mentioned this pull request Feb 26, 2020
@vitsadecky
Copy link
Author

vitsadecky commented Feb 26, 2020

@migo315 perfect, but I would need it in version 3.5.0 as well :-)

Can you apply this commit for older versions, especially 3.5 version and then you can create 3.5.1 version, please?

I suppose this MR is useless (same change from 3.5.0 tag):
#74

@vitsadecky vitsadecky deleted the fix-invokable-controllers branch February 27, 2020 11:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants