Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(primitives): Create our own custom execution types #1856

Merged
merged 23 commits into from
Aug 7, 2024
Prev Previous commit
Next Next commit
more removal of geth primitives
  • Loading branch information
itsdevbear committed Aug 7, 2024
commit 9b6c9abf342ab6bb54b0e9ec5190314427b0cd7e
4 changes: 1 addition & 3 deletions mod/execution/pkg/client/engine.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ import (
engineerrors "github.com/berachain/beacon-kit/mod/engine-primitives/pkg/errors"
"github.com/berachain/beacon-kit/mod/errors"
"github.com/berachain/beacon-kit/mod/execution/pkg/client/ethclient"
gethprimitives "github.com/berachain/beacon-kit/mod/geth-primitives"
"github.com/berachain/beacon-kit/mod/primitives/pkg/common"
"github.com/berachain/beacon-kit/mod/primitives/pkg/version"
)
Expand Down Expand Up @@ -104,8 +103,7 @@ func (s *EngineClient[
attrs.GetSuggestedFeeRecipient() == (common.ExecutionAddress{}) {
s.logger.Warn(
"Suggested fee recipient is not configured 🔆",
"fee-recipent", gethprimitives.DisplayBytes(
gethprimitives.ZeroAddress[:]).TerminalString(),
"fee-recipent", attrs.GetSuggestedFeeRecipient(),
)
}

Expand Down
5 changes: 2 additions & 3 deletions mod/primitives/pkg/net/jwt/jwt_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,15 +25,14 @@ import (
"strings"
"testing"

gethprimitives "github.com/berachain/beacon-kit/mod/geth-primitives"
"github.com/berachain/beacon-kit/mod/primitives/pkg/encoding/hex"
"github.com/berachain/beacon-kit/mod/primitives/pkg/net/jwt"
"github.com/stretchr/testify/require"
)

func TestNewFromHex(t *testing.T) {
wantValid := jwt.Secret(
gethprimitives.FromHex(
hex.MustToBytes(
"1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef",
),
)
Expand Down Expand Up @@ -92,7 +91,7 @@ func TestSecretString(t *testing.T) {
{
name: "mask secret correctly",
secret: jwt.Secret(
gethprimitives.FromHex(
hex.MustToBytes(
"1234567890abcdef1234567890abcdef1234567890abcdef1234567890abcdef",
),
),
Expand Down
Loading