-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(block-store): fix get, store block roots -> slot for api block id support #1783
Conversation
Warning Rate limit exceeded@archbear has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 43 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThe recent changes enhance the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (2)
- mod/storage/pkg/block/store.go (3 hunks)
- mod/storage/pkg/block/types.go (1 hunks)
Additional comments not posted (5)
mod/storage/pkg/block/types.go (1)
25-28
: LGTM! Ensure the new methods are used correctly.The addition of the generic type parameter
T
and the new methodsNewFromSSZ
andVersion
are well-implemented and enhance the interface's flexibility and type safety.However, ensure that the new methods are correctly implemented and used in the codebase.
mod/storage/pkg/block/store.go (4)
32-32
: Verify the removal ofpruner.Prunable
interface enforcement.The removal of the line enforcing the
pruner.Prunable
interface might indicate a design decision to decouple from thepruner
package or simplify the codebase.What is the reasoning behind removing this line? Ensure that this change does not affect the functionality of the
KVStore
.
47-47
: LGTM!The update to
KVStore[BeaconBlockT BeaconBlock[BeaconBlockT]]
enhances type safety and flexibility in handlingBeaconBlock
instances.
56-71
: LGTM!The updates to the
NewStore
function match the newKVStore
type declaration and refine the codec initialization, centralizing codec handling and improving the management of the codec's state.
86-86
: LGTM!The addition of the line to set the active fork version of the block in the
Set
method ensures that the correct fork version is applied during block storage operations.
Summary by CodeRabbit
New Features
KVStore
andBeaconBlock
interfaces.BeaconBlock
interface.Improvements
KVStore
, facilitating better access and state management.