Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): non breaking change #1655

Conversation

ocnc2
Copy link
Contributor

@ocnc2 ocnc2 commented Jun 29, 2024

Summary by CodeRabbit

  • Refactor
    • Improved dependency management by updating import statements.
    • Enhanced configuration handling by replacing viper.GetViper() with client.GetViperFromCmd(cmd).

@ocnc2 ocnc2 enabled auto-merge (squash) June 29, 2024 03:21
Copy link

codecov bot commented Jun 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 22.99%. Comparing base (12998fb) to head (cfc6afa).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1655   +/-   ##
=======================================
  Coverage   22.99%   22.99%           
=======================================
  Files         268      268           
  Lines       11840    11840           
  Branches       18       18           
=======================================
  Hits         2723     2723           
  Misses       8989     8989           
  Partials      128      128           
Files Coverage Δ
mod/cli/pkg/commands/deposit/create.go 0.00% <0.00%> (ø)
mod/cli/pkg/commands/genesis/deposit.go 0.00% <0.00%> (ø)

@ocnc2 ocnc2 added the skill issue https://www.urbandictionary.com/define.php?term=skill%20issue%5C label Jun 29, 2024
Copy link
Contributor

coderabbitai bot commented Jun 29, 2024

Walkthrough

The recent changes update import statements in key files within the mod/cli/pkg/commands/deposit and mod/cli/pkg/commands/genesis packages. Specifically, viper.GetViper() calls have been replaced with client.GetViperFromCmd(cmd) to streamline the usage of Viper within these commands. This update ensures better integration with cosmos-sdk and enhances code readability and maintainability.

Changes

Files Change Summary
mod/cli/pkg/commands/deposit/create.go Added github.com/cosmos/cosmos-sdk/client as an import and replaced viper.GetViper() with client.GetViperFromCmd(cmd)
mod/cli/pkg/commands/genesis/deposit.go Added github.com/cosmos/cosmos-sdk/client as an import, replaced viper.GetViper() with client.GetViperFromCmd(cmd), and updated the getBLSSigner function signature to accept a viper.Viper parameter

In code we trust, with changes bright,
Refactoring flows by day and night.
Viper now commands with cheer,
Integration clear, nothing to fear.
Cosmos SDK at our side,
In harmony, we now abide.


Tip

Early access features
  • OpenAI gpt-4o model for reviews and chat.

Note:

  • You can disable early access features from the CodeRabbit UI or by setting early_access: false in the CodeRabbit configuration file.
  • Please join our Discord Community to provide feedback and report issues.
  • OSS projects are always opted into early access features.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 12998fb and cfc6afa.

Files selected for processing (2)
  • mod/cli/pkg/commands/deposit/create.go (2 hunks)
  • mod/cli/pkg/commands/genesis/deposit.go (3 hunks)
Additional comments not posted (4)
mod/cli/pkg/commands/deposit/create.go (2)

34-34: Import Addition Approved.

The import of github.com/cosmos/cosmos-sdk/client is appropriate for the updated configuration handling.


154-154: Verify Correctness of Configuration Handling.

Ensure that client.GetViperFromCmd(cmd) correctly handles the configuration as expected.

mod/cli/pkg/commands/genesis/deposit.go (2)

40-40: Import Addition Approved.

The import of github.com/cosmos/cosmos-sdk/client is consistent with the changes in create.go.


192-197: Function Signature Change Approved.

The function getBLSSigner now requires a *viper.Viper parameter, which aligns with the updated configuration handling.

Ensure that client.GetViperFromCmd(cmd) correctly handles the configuration as expected.

@ocnc2 ocnc2 merged commit e7570f4 into main Jun 29, 2024
17 checks passed
@ocnc2 ocnc2 deleted the this-is-literally-a-breaking-change-in-server-v2-that-i-spent-1-hour-debugging branch June 29, 2024 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skill issue https://www.urbandictionary.com/define.php?term=skill%20issue%5C
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant