-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): non breaking change #1655
chore(cli): non breaking change #1655
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1655 +/- ##
=======================================
Coverage 22.99% 22.99%
=======================================
Files 268 268
Lines 11840 11840
Branches 18 18
=======================================
Hits 2723 2723
Misses 8989 8989
Partials 128 128
|
WalkthroughThe recent changes update import statements in key files within the Changes
Tip Early access features
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Files selected for processing (2)
- mod/cli/pkg/commands/deposit/create.go (2 hunks)
- mod/cli/pkg/commands/genesis/deposit.go (3 hunks)
Additional comments not posted (4)
mod/cli/pkg/commands/deposit/create.go (2)
34-34
: Import Addition Approved.The import of
github.com/cosmos/cosmos-sdk/client
is appropriate for the updated configuration handling.
154-154
: Verify Correctness of Configuration Handling.Ensure that
client.GetViperFromCmd(cmd)
correctly handles the configuration as expected.mod/cli/pkg/commands/genesis/deposit.go (2)
40-40
: Import Addition Approved.The import of
github.com/cosmos/cosmos-sdk/client
is consistent with the changes increate.go
.
192-197
: Function Signature Change Approved.The function
getBLSSigner
now requires a*viper.Viper
parameter, which aligns with the updated configuration handling.Ensure that
client.GetViperFromCmd(cmd)
correctly handles the configuration as expected.
Summary by CodeRabbit
viper.GetViper()
withclient.GetViperFromCmd(cmd)
.