Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(abci): nil error #1572

Merged
merged 5 commits into from
Jun 23, 2024
Merged

feat(abci): nil error #1572

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
edae177
bet
itsdevbear Jun 23, 2024
89daf00
x
itsdevbear Jun 23, 2024
06bd557
bet
itsdevbear Jun 23, 2024
2ada3ad
bet
itsdevbear Jun 23, 2024
3a1ed68
bet
itsdevbear Jun 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
bet
  • Loading branch information
@itsdevbear
itsdevbear committed Jun 23, 2024
commit edae177fc6d8900613ae7ac84fd467f2e3e22436
8 changes: 3 additions & 5 deletions mod/runtime/pkg/middleware/abci.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,9 +291,10 @@ func (h *ABCIMiddleware[
h.chainSpec.ActiveForkVersionForSlot(
math.Slot(req.Height),
))

if err != nil {
h.errCh <- errors.Join(err, ErrBadExtractBlockAndBlocks)
// We push nil onto the channel so that we don't error out in
// endBlock().
h.errCh <- nil
return
}

Expand Down Expand Up @@ -333,9 +334,6 @@ func (h *ABCIMiddleware[
case <-ctx.Done():
return nil, ctx.Err()
case err := <-h.errCh:
if errors.Is(err, ErrBadExtractBlockAndBlocks) {
err = nil
}
return nil, err
case result := <-h.valUpdatesCh:
return iter.MapErr(
Expand Down
Loading