Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ssz): adjust the initial offset of variables-length fields #1492

Merged
merged 7 commits into from
Jun 18, 2024
Merged

fix(ssz): adjust the initial offset of variables-length fields #1492

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
35cff6c
adjust the initial offset of variables offset
TropicalDog17 Jun 15, 2024
efbb77f
remove comment
TropicalDog17 Jun 15, 2024
44c835a
update comment
TropicalDog17 Jun 15, 2024
2c429af
Merge branch 'main' into tuan/fix-serializer-offset
TropicalDog17 Jun 15, 2024
1cd88cd
fix gosec
TropicalDog17 Jun 15, 2024
41ecdb4
Merge branch 'tuan/fix-serializer-offset' of github.com:orbitorg/beac…
TropicalDog17 Jun 15, 2024
576ee4a
Merge branch 'main' into tuan/fix-serializer-offset
TropicalDog17 Jun 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove comment
  • Loading branch information
@TropicalDog17
TropicalDog17 committed Jun 15, 2024
commit efbb77f75c3e3cb69c0197294b42bf6c5d3ea1ba
3 changes: 0 additions & 3 deletions mod/primitives/pkg/ssz/v2/lib/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,9 +190,6 @@ func InterleaveOffsets(
for i := range len(variableParts) {
variableOffsets[i] = ssz.MarshalU32(uint32(offsetSum))
TropicalDog17 marked this conversation as resolved.
Show resolved Hide resolved
offsetSum += variableLengths[i]
// #nosec:G701 // converting an int of max is 4294967295 to uint64 max
// of 2147483647.
// Wont realisticially overflow.
}

fixedPartsWithOffsets := make([][]byte, len(fixedParts))
Expand Down