Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(validator): Forkchoice update logic should be more consolidated #1373

Merged
merged 41 commits into from
Jun 7, 2024

Conversation

itsdevbear
Copy link
Member

@itsdevbear itsdevbear commented Jun 7, 2024

We need to manage FCU's and the EL in a more sophisticated fashion, moving all FCU calls into a single place is a good place to start

@itsdevbear itsdevbear requested a review from ocnc as a code owner June 7, 2024 05:36
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 263 lines in your changes missing coverage. Please review.

Project coverage is 21.75%. Comparing base (6be1464) to head (7340c79).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1373   +/-   ##
=======================================
  Coverage   21.75%   21.75%           
=======================================
  Files         231      232    +1     
  Lines       11157    11154    -3     
  Branches       18       18           
=======================================
  Hits         2427     2427           
+ Misses       8568     8565    -3     
  Partials      162      162           
Files Coverage Δ
mod/beacon/validator/metrics.go 0.00% <ø> (ø)
mod/beacon/validator/service.go 0.00% <ø> (ø)
mod/beacon/validator/state.go 0.00% <ø> (ø)
mod/execution/pkg/client/client.go 0.00% <0.00%> (ø)
mod/runtime/pkg/runtime/runtime.go 0.00% <0.00%> (ø)
mod/beacon/blockchain/process.go 0.00% <0.00%> (ø)
mod/runtime/pkg/runtime/middleware/validator.go 0.00% <0.00%> (ø)
testing/e2e/suite/setup.go 0.00% <0.00%> (ø)
mod/node-core/pkg/config/spec/devnet.go 0.00% <0.00%> (ø)
beacond/cmd/main.go 0.00% <0.00%> (ø)
... and 8 more

@itsdevbear itsdevbear enabled auto-merge June 7, 2024 16:03
@itsdevbear itsdevbear added this pull request to the merge queue Jun 7, 2024
Merged via the queue into main with commit 9e6db25 Jun 7, 2024
15 checks passed
@itsdevbear itsdevbear deleted the blockchain-builder branch June 7, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant