forked from nodejs/node
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix process.nextTick throw call sites
This patch now reports the proper throw call site for exceptions triggered within process.nextTick. So instead of this: node.js:201 throw e; // process.nextTick error, or 'error' event on first tick ^ You will now see: mydir/myscript.js:15 throw new Error('My Error'); ^ From my testing this patch causes no performance regressions, but does greatly simplify processing the nextTickQueue.
- Loading branch information
Showing
6 changed files
with
28 additions
and
32 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
before | ||
|
||
node.js:* | ||
throw e; // process.nextTick error, or 'error' event on first tick | ||
^ | ||
module.js:311 | ||
throw err; | ||
^ | ||
RangeError: Maximum call stack size exceeded |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
before | ||
|
||
node.js:* | ||
throw e; // process.nextTick error, or 'error' event on first tick | ||
^ | ||
module.js:311 | ||
throw err; | ||
^ | ||
MyCustomError: This is a custom message |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
before | ||
|
||
node.js:* | ||
throw e; // process.nextTick error, or 'error' event on first tick | ||
^ | ||
module.js:311 | ||
throw err; | ||
^ | ||
[object Object] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters