Skip to content

Commit

Permalink
build: fix g++ 4.8 build, disable -Werror
Browse files Browse the repository at this point in the history
Turn off -Werror when building V8, it hits -Werror=unused-local-typedefs
with g++ 4.8.  The warning itself is harmless so don't abort the build.

This was originally implemented in commit d2ab314 back in 2011 but the
build process has gone through a few iterations since then, that change
no longer works.
  • Loading branch information
bnoordhuis authored and tjfontaine committed Mar 23, 2014
1 parent 43a29f5 commit 7989f42
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
1 change: 1 addition & 0 deletions common.gypi
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{
'variables': {
'werror': '', # Turn off -Werror in V8 build.
'visibility%': 'hidden', # V8's visibility setting
'target_arch%': 'ia32', # set v8's target architecture
'host_arch%': 'ia32', # set v8's host architecture
Expand Down
3 changes: 0 additions & 3 deletions node.gyp
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
{
'variables': {
'v8_use_snapshot%': 'true',
# Turn off -Werror in V8
# See http://codereview.chromium.org/8159015
'werror': '',
'node_use_dtrace%': 'false',
'node_use_etw%': 'false',
'node_use_perfctr%': 'false',
Expand Down

0 comments on commit 7989f42

Please sign in to comment.