doc: require passing CI for landing code

PR-URL: nodejs#19458 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Daniel Bevenius <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Jon Moss <[email protected]>
bengl · Mar 22, 2018 · 01b74d1 · 01b74d1
1 parent a72bfb9
commit 01b74d1
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md
@@ -196,6 +196,14 @@ and must be subjected to continuous integration tests on the
 [project CI server](https://ci.nodejs.org/). The pull request should have a CI
 status indicator.
 
+Do not land any Pull Requests without passing (green or yellow) CI runs. If you
+believe any failed (red or grey) CI sub-tasks are unrelated to the change in the
+Pull Request, you may re-run the sub-task to try to see if it passes. If re-runs
+of all failed sub-tasks pass, it is permissible to land the Pull Request but
+only if the initial failures are believed in good faith to be unrelated to the
+changes in the Pull Request. Otherwise, reasonable steps must be taken to
+confirm that the changes are not resulting in an unreliable test.
+
 #### Useful CI Jobs
 
 * [`node-test-pull-request`](https://ci.nodejs.org/job/node-test-pull-request/)